Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: swiftlint issues in Utilities.swift #779

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix: swiftlint issues in Utilities.swift #779

merged 1 commit into from
Feb 14, 2023

Conversation

JeneaVranceanu
Copy link
Collaborator

Summary of Changes

Fixing all SwiftLint issues in Utilities.swift file.

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@yaroslavyaroslav
Copy link
Collaborator

Just a hint, that if you type in PR description smth like "Closes 778" the issue would automatically closed on merge.

@JeneaVranceanu
Copy link
Collaborator Author

Just a hint, that if you type in PR description smth like "Closes 778" the issue would automatically closed on merge.

I know, but it doesn't close #778 as it's a different issue.
This PR just fixes SwiftLint issues while #778 is a bug I found while I was fixing SwiftLint issues.

janndriessen
janndriessen approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@janndriessen janndriessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think going by file is a good way to have easily reviewable swiftlint PR's 👌

@JeneaVranceanu JeneaVranceanu merged commit 931026a into web3swift-team:develop Feb 14, 2023
@JeneaVranceanu JeneaVranceanu deleted the fix/swiftlint-fixes-continuation branch February 14, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janndriessen janndriessen janndriessen approved these changes

@yaroslavyaroslav yaroslavyaroslav yaroslavyaroslav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeneaVranceanu @yaroslavyaroslav @janndriessen